Reorganize runner tests following previous class renaming #2991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65090663 |
|
This pull request was exported from Phabricator. Differential Revision: D65090663 |
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
Oct 30, 2024
) Summary: Pull Request resolved: facebook#2991 See D64969707 for context. This diff: * Moves the parts of `tests/runners/test_botorch_test_problem` that pertain to the runner into `tests/test_benchmark_runner.py` * Moves the parts that pertain to `BoTorchTestFunction` to `tests/benchmark_test_functions/test_botorch_test_function.py` * Moves `tests/runners/test_surrogate_runner.py` to `tests/benchmark_test_functions/test_surrogate_test_function.py` Differential Revision: D65090663
esantorella
force-pushed
the
export-D65090663
branch
from
9082f72
to
b03c935
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2991 +/- ##
=======================================
Coverage 95.61% 95.61%
=======================================
Files 483 485 +2
Lines 48970 48977 +7
=======================================
+ Hits 46821 46828 +7
Misses 2149 2149 ☔ View full report in Codecov by Sentry. |
Summary: Pull Request resolved: facebook#2977 ** Context** The current structure of the code is such: * Each `BenchmarkProblem` has a `BenchmarkRunner` * ` BenchmarkRunner` is the only runner * A` BenchmarkRunner` has a `ParamBasedTestProblem`, which is either a `BoTorchTestProblem`, `SurrogateTestFunction`, or a special subclass such as `Jenatton`. The directory structure and names have gotten quite out of touch with the code. **New class names** * `ParamBasedTestProblem` -> `TestFunction` (maybe we should call this `BenchmarkTestFunction`?) * `BoTorchTestProblem` -> `BoTorchTestFunction` **New directory structure** | benchmark_problem.py | problems/ | | synthetic/hss/jenatton.py | | ... | benchmark_runner.py | test_function.py | test_function.py | test_functions/ | | botorch_test.py | | surrogate.py Future diffs: * rename `BenchmarkRunner.test_problem` to `BenchmarkRunner.test_function` (D65088791) Differential Revision: D64969707 Reviewed By: saitcakmak, Balandat
…n`, because it is a `BenchmarkTestFunction` Summary: Rename `test_problem` attribute of `BenchmarkRunner` to `test_function`, because it is a `BenchmarkTestFunction` Differential Revision: D65088791
) Summary: Pull Request resolved: facebook#2991 See D64969707 for context. This diff: * Moves the parts of `tests/runners/test_botorch_test_problem` that pertain to the runner into `tests/test_benchmark_runner.py` * Moves the parts that pertain to `BoTorchTestFunction` to `tests/benchmark_test_functions/test_botorch_test_function.py` * Moves `tests/runners/test_surrogate_runner.py` to `tests/benchmark_test_functions/test_surrogate_test_function.py` Reviewed By: Balandat Differential Revision: D65090663
esantorella
force-pushed
the
export-D65090663
branch
from
b03c935
to
05c52e2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65090663 |
|
This pull request has been merged in 46fa5a5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
See D64969707 for context.
This diff:
tests/runners/test_botorch_test_problemthat pertain to the runner intotests/test_benchmark_runner.pyBoTorchTestFunctiontotests/benchmark_test_functions/test_botorch_test_function.pytests/runners/test_surrogate_runner.pytotests/benchmark_test_functions/test_surrogate_test_function.pyDifferential Revision: D65090663